FT0: Use dead channel map in digitizer#12340
Conversation
Enables the use of the dead channel map from CCDB in the FT0 digitizer as default. Hits in dead channels will not be processed. To disable checking the dead channel map, pass `--FT0Digitizer --disable-dead-channel-map` to the digitizer workflow.
andreasmolander
requested review from
afurs,
arvindkhuntia,
benedikt-voelkel,
jotwinow,
mslupeck,
sawenzel and
shahor02
as code owners
|
I want to set the dead channel map as an InputSpec for the digitizer. I also want to be able to disable its use with a command line argument (to the digitizer), and I want this argument to be an option of the FT0 digitizer task and not the "global" digitizer task, just to not touch the global task and keep it clean. In case the dead channel map is disabled, should I also disable the InputSpec (CCDBParamSpec)? Or is it enough to set query rate to -1? When used, the map should be fetched only once. As the disabling is a parameter of the FT0 task, which is defined at the same time as the input specs to the task, I'm not sure how to make the InputSpec conditional. My question is in other words, does it hurt to always fetch the map (with query rate = -1), no matter if it's used or not? (Basically it should never not be used.) |
|
Btw, the naming of the |
Enables the use of the dead channel map from CCDB in the FDD digitizer as default. Hits in dead channels will not be processed. To disable checking the dead channel map, pass --FDDDigitizer --disable-dead-channel-map to the digitizer workflow.
|
I included the same changes for FDD. I also noticed that |
shahor02
left a comment
shahor02
left a comment
There was a problem hiding this comment.
The comment below is just of the record, the failures are unrelated, merging.
| auto deadChannelMap = pc.inputs().get<o2::fit::DeadChannelMap*>("fdddeadchannelmap"); | ||
| mDigitizer.setDeadChannelMap(deadChannelMap.get()); |
There was a problem hiding this comment.
This will work, but the good way of setting the ccdb object is to just call here
if (mUpdateDeadChannelMap && mUseDeadChannelMap) {
mDigitizer.setDeadChannelMap(deadChannelMap.get());
}
if (matcher == ConcreteDataMatcher("FDD", "DeadChannelMap", 0)) {
mUpdateDeadChannelMap = false;
mDigitizer.setDeadChannelMap((const o2::fit::DeadChannelMap*)obj);
}
* FT0: Use dead channel map in digitizer Enables the use of the dead channel map from CCDB in the FT0 digitizer as default. Hits in dead channels will not be processed. To disable checking the dead channel map, pass `--FT0Digitizer --disable-dead-channel-map` to the digitizer workflow. * FDD: Use dead channel map in digitizer Enables the use of the dead channel map from CCDB in the FDD digitizer as default. Hits in dead channels will not be processed. To disable checking the dead channel map, pass --FDDDigitizer --disable-dead-channel-map to the digitizer workflow.
* FT0: Use dead channel map in digitizer Enables the use of the dead channel map from CCDB in the FT0 digitizer as default. Hits in dead channels will not be processed. To disable checking the dead channel map, pass `--FT0Digitizer --disable-dead-channel-map` to the digitizer workflow. * FDD: Use dead channel map in digitizer Enables the use of the dead channel map from CCDB in the FDD digitizer as default. Hits in dead channels will not be processed. To disable checking the dead channel map, pass --FDDDigitizer --disable-dead-channel-map to the digitizer workflow.
3 participants
Enables the use of the dead channel map from CCDB in the FT0 digitizer as default. Hits in dead channels will not be processed. To disable checking the dead channel map, pass
--FT0Digitizer --disable-dead-channel-mapto the digitizer workflow.